Fix mail design #1446

eppfel · 2016-09-19T14:03:34Z

As in issue #1326

I imitate the nextcloud header.

I replced the gif with the png, but maybe some other apps use it.

@nextcloud/designers

Todo

typo "an nextlcoud"
fix the gif/png
~~header, just with a circled logo~~
bold username and link

mention-bot · 2016-09-19T14:03:40Z

@eppfel, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle, @rullzer and @scolebrook to be potential reviewers

MorrisJobke · 2016-09-19T15:52:13Z

I have found following project that aims for nice responsive emails: https://htmlemail.io/

maybe we lend some concepts from them ;)

Edit: https://mjml.io/ also looks nice

jancborchardt · 2016-10-18T09:47:35Z

@eppfel what do you think of just using the blue logo there? That would look a lot nicer and simpler on white probably.

Btw there’s a typo in the mail: »an Nextcloud account«

eppfel · 2016-10-18T11:44:50Z

@jancborchardt Yeah, blue logo would be more fitting, I guess. But that still leaves us with the theming question...

jancborchardt · 2016-10-18T12:18:34Z

I guess just changing for the correct logo is easy with the dynamic icon creation by @juliushaertl #840 ;)

juliushaertl · 2016-10-18T12:33:39Z

This should already be quite easy even without #840.

Just for the theming stuff, it would of course be simpler to keep the blue backgorund with the white logo, just as it is used everywhere else in the Nextcloud UI at the moment. Otherwise we would again introduce a second logo, that may need some extra handling in case of theming.

eppfel · 2016-10-18T15:54:40Z

Just for the theming stuff, it would of course be simpler to keep the blue backgorund with the white logo, just as it is used everywhere else in the Nextcloud UI at the moment. Otherwise we would again introduce a second logo, that may need some extra handling in case of theming.

That was actually what I was referring to.

jancborchardt · 2016-10-18T17:12:41Z

Maybe then make it a blue circle, kinda like the stickers? That might look nicer than the rectangle which feels a bit misplaced.

jancborchardt · 2016-11-03T12:56:33Z

@eppfel what do you think about the circle idea? We could center that icon too maybe.

And while we’re at improving the HTML mail, maybe also bold the username and the access link?

eppfel · 2016-11-04T11:04:14Z

@jancborchardt Sounds all good ideas. I'm just super busy ATM.
If someone wants to hijack this one... feel free!

schiessle · 2016-11-09T10:02:07Z

Please also make sure to adjust the share-by-mail template: https://github.com/nextcloud/server/tree/master/apps/sharebymail/templates Thanks!

eppfel · 2016-11-28T15:54:09Z

I want to leave this as minor fix, instead of making it an overall Mail redesign. Because the state it is now, is not acceptable at all. We then even could look at backporting it.
And after the discussion from #2071 is finished, we can make a new PR for the redesign.

What do you think? @jancborchardt @MorrisJobke @schiessle

MorrisJobke · 2016-11-29T15:11:43Z

I just rebased :)

MorrisJobke · 2016-11-29T15:18:24Z

I have no idea why, but the "shared a file with you" email(left) has a wrong URL ('/themes/` should not be in there) but the "new user" email works fine(right):

@eppfel: Any idea? And remind that I rebased and you need to fetch that version first.

cc @rullzer @juliushaertl for this

MorrisJobke · 2016-11-29T15:27:50Z

Ah found it - there is a new template ;)

MorrisJobke · 2016-11-29T15:32:12Z

I just tested this and it works really nice 👍

MorrisJobke · 2016-11-29T15:50:44Z

I removed the leftovers from #1929 - cc @rullzer

Signed-off-by: Felix A. Epp <work@felixepp.de>

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

eppfel · 2016-11-30T00:41:15Z

@MorrisJobke Signed, rebased ❗️, but typo and bold username/url are still there. I do not thoroughly understand transifex, yet.

codecov-io · 2016-11-30T01:01:05Z

Current coverage is 56.99% (diff: 100%)

Merging #1446 into master will increase coverage by 0.02%

@@             master      #1446   diff @@
==========================================
  Files          1191       1189     -2   
  Lines         72072      72037    -35   
  Methods        7299       7299          
  Messages          0          0          
  Branches       1210       1210          
==========================================
- Hits          41057      41056     -1   
+ Misses        31015      30981    -34   
  Partials          0          0

Powered by Codecov. Last update 83cef4e...8e361b7

* a nextcloud * Strong username & url Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

rullzer · 2016-11-30T07:53:01Z

@eppfel I fixed the missing todo's. Please double check.

Else good to go from my POV 👍

eppfel · 2016-11-30T08:29:17Z

settings/templates/email.new_user.php

@@ -11,7 +11,7 @@
 					<td width="20px">&nbsp;</td>
 					<td style="font-weight:normal; font-size:0.8em; line-height:1.2em; font-family:verdana,'arial',sans;">
 						<?php
-						print_unescaped($l->t('Hey there,<br><br>just letting you know that you now have an %s account.<br><br>Your username: %s<br>Access it: <a href="%s">%s</a><br><br>', array($theme->getName(), $_['username'], $_['url'], $_['url'])));
+						print_unescaped($l->t('Hey there,<br><br>just letting you know that you now have a %s account.<br><br>Your username: <strong>%s</strong><br>Access it: <strong><a href="%s">%s</a></strong><br><br>', array($theme->getName(), $_['username'], $_['url'], $_['url'])));


Just out of interest? How does transifex allocate the translations, if the key changes?

It shows a new untranslated string. but it does remember the original one and shows it in 'likely' matches or something. So that users have help in translating the new one.

Ah, ok. So, it's fine changing these and not worry about the translation. Thanks for the clarification. ❤️

Yep - just change it and it will show up after 3 am on transifex ;)

MorrisJobke · 2016-11-30T10:31:40Z

👍

eppfel added 1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. labels Sep 19, 2016

MariusBluem added this to the Nextcloud 11.0 milestone Sep 19, 2016

eppfel self-assigned this Oct 18, 2016

jancborchardt added good first issue Small tasks with clear documentation about how and in which place you need to fix things in. help wanted labels Nov 4, 2016

eppfel removed their assignment Nov 18, 2016

eppfel mentioned this pull request Nov 28, 2016

Better designed emails when sharing links and calendar etc #2071

Closed

MorrisJobke force-pushed the fix-mail-design branch from 6e3f6fd to 07ac50d Compare November 29, 2016 15:11

MorrisJobke added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Nov 29, 2016

eppfel and others added 2 commits November 30, 2016 01:06

Fix mail header logo [fixes #1326]

6aa79ca

Signed-off-by: Felix A. Epp <work@felixepp.de>

Update sharedbymail template

01867b4

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Remove leftovers from #1929

224c89c

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

eppfel force-pushed the fix-mail-design branch from fc35a9c to 224c89c Compare November 30, 2016 00:14

Fix minor mail issues

8e361b7

* a nextcloud * Strong username & url Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

eppfel commented Nov 30, 2016

View reviewed changes

MorrisJobke merged commit 86168c8 into master Nov 30, 2016

MorrisJobke deleted the fix-mail-design branch November 30, 2016 10:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix mail design #1446

Fix mail design #1446

eppfel commented Sep 19, 2016 •

edited

Loading

mention-bot commented Sep 19, 2016

MorrisJobke commented Sep 19, 2016 •

edited

Loading

jancborchardt commented Oct 18, 2016

eppfel commented Oct 18, 2016 •

edited

Loading

jancborchardt commented Oct 18, 2016

juliushaertl commented Oct 18, 2016

eppfel commented Oct 18, 2016

jancborchardt commented Oct 18, 2016

jancborchardt commented Nov 3, 2016

eppfel commented Nov 4, 2016

schiessle commented Nov 9, 2016 •

edited by MorrisJobke

Loading

eppfel commented Nov 28, 2016 •

edited

Loading

MorrisJobke commented Nov 29, 2016

MorrisJobke commented Nov 29, 2016 •

edited

Loading

MorrisJobke commented Nov 29, 2016

MorrisJobke commented Nov 29, 2016

MorrisJobke commented Nov 29, 2016

eppfel commented Nov 30, 2016 •

edited

Loading

codecov-io commented Nov 30, 2016 •

edited

Loading

rullzer commented Nov 30, 2016

eppfel Nov 30, 2016

rullzer Nov 30, 2016

eppfel Nov 30, 2016

MorrisJobke Nov 30, 2016

MorrisJobke commented Nov 30, 2016

Fix mail design #1446

Fix mail design #1446

Conversation

eppfel commented Sep 19, 2016 • edited Loading

Todo

mention-bot commented Sep 19, 2016

MorrisJobke commented Sep 19, 2016 • edited Loading

jancborchardt commented Oct 18, 2016

eppfel commented Oct 18, 2016 • edited Loading

jancborchardt commented Oct 18, 2016

juliushaertl commented Oct 18, 2016

eppfel commented Oct 18, 2016

jancborchardt commented Oct 18, 2016

jancborchardt commented Nov 3, 2016

eppfel commented Nov 4, 2016

schiessle commented Nov 9, 2016 • edited by MorrisJobke Loading

eppfel commented Nov 28, 2016 • edited Loading

MorrisJobke commented Nov 29, 2016

MorrisJobke commented Nov 29, 2016 • edited Loading

MorrisJobke commented Nov 29, 2016

MorrisJobke commented Nov 29, 2016

MorrisJobke commented Nov 29, 2016

eppfel commented Nov 30, 2016 • edited Loading

codecov-io commented Nov 30, 2016 • edited Loading

Current coverage is 56.99% (diff: 100%)

rullzer commented Nov 30, 2016

eppfel Nov 30, 2016

Choose a reason for hiding this comment

rullzer Nov 30, 2016

Choose a reason for hiding this comment

eppfel Nov 30, 2016

Choose a reason for hiding this comment

MorrisJobke Nov 30, 2016

Choose a reason for hiding this comment

MorrisJobke commented Nov 30, 2016

eppfel commented Sep 19, 2016 •

edited

Loading

MorrisJobke commented Sep 19, 2016 •

edited

Loading

eppfel commented Oct 18, 2016 •

edited

Loading

schiessle commented Nov 9, 2016 •

edited by MorrisJobke

Loading

eppfel commented Nov 28, 2016 •

edited

Loading

MorrisJobke commented Nov 29, 2016 •

edited

Loading

eppfel commented Nov 30, 2016 •

edited

Loading

codecov-io commented Nov 30, 2016 •

edited

Loading